Create Github.Repo.RulesetModified rule #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Background The cool kidz these days are using ruleset instead of or in combination with branch protection rules. This rule alerts to modifications (update, destroy) of rulesets and adds an INFO-level signal for ruleset creations if desired for future correlation rules. Filters can be applied in global_filter_github and github_alert_context is enriched specific to repo ruleset changes. [1] https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/about-rulesets ### Changes - Create GitHub.Repo.RulsetModified rule - Tests for each create/update/destroy event type - Update the github.yml pack ### Testing pat test, make lint
arielkr256
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
@geoffg-sentry very nice! Made a couple of minor adjustments but overall looks great.
| ctx["operation_type"] = event.get("operation_type", "") | ||
| ctx["ruleset_bypass_actors"] = event.deep_walk("ruleset_bypass_actors") | ||
| ctx["ruleset_conditions"] = event.deep_walk("ruleset_conditions") | ||
| ctx["ruleset_rules"] = event.deep_walk("ruleset_rules") |
arielkr256
reviewed
Jan 9, 2025
arielkr256
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The cool kidz these days are using ruleset instead of or in combination with branch protection rules. This rule alerts to modifications (update, destroy) of rulesets and adds an INFO-level signal for ruleset creations if desired for future correlation rules. Filters can be applied in global_filter_github and the github_alert_context is enriched specific to repo ruleset changes.
[1] https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/about-rulesets
Changes
Testing
pat test, make lint